Skip to content

src: remove outdated comments in contextify#62932

Open
legendecas wants to merge 1 commit intonodejs:mainfrom
legendecas:contextify-comment
Open

src: remove outdated comments in contextify#62932
legendecas wants to merge 1 commit intonodejs:mainfrom
legendecas:contextify-comment

Conversation

@legendecas
Copy link
Copy Markdown
Member

@legendecas legendecas commented Apr 24, 2026 •
edited
Loading

With https://chromium-review.googlesource.com/c/v8/v8/+/7718821, there is no need for Node.js to detect a contextual store in ContextifyContext::PropertySetterCallback.

Refs: #61898

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Apr 24, 2026
@legendecas legendecas added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. labels Apr 24, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.65%. Comparing base (fcff458) to head (e641303).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62932      +/-   ##
==========================================
- Coverage   91.48%   89.65%   -1.83%     
==========================================
  Files         356      706     +350     
  Lines      150602   219220   +68618     
  Branches    23709    42019   +18310     
==========================================
+ Hits       137777   196543   +58766     
- Misses      12554    14595    +2041     
- Partials      271     8082    +7811
Files with missing lines Coverage Δ
src/node_contextify.cc 82.68% <ø> (ø)

... and 469 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 24, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 24, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 24, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72912/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@IlyasShabi IlyasShabi IlyasShabi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@legendecas @nodejs-github-bot @lpinca @anonrig @IlyasShabi @addaleax